Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename jvm.classes.current_loaded to jvm.classes.count #60

Merged
merged 14 commits into from
Aug 16, 2023
Merged

Rename jvm.classes.current_loaded to jvm.classes.count #60

merged 14 commits into from
Aug 16, 2023

Conversation

trask
Copy link
Member

@trask trask commented May 26, 2023 •
edited
Loading

@trask trask force-pushed the rename-classes-current-loaded branch from 70bc349 to 625d14d Compare May 26, 2023 19:34
@trask trask mentioned this pull request May 26, 2023
Closed
@trask trask marked this pull request as ready for review May 26, 2023 19:37
@trask trask requested review from a team May 26, 2023 19:37
joaopgrassi
joaopgrassi approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@joaopgrassi joaopgrassi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get this moving (as it aligns with our current guidelines) but as @trask said we will need to revisit once #50 is solved.

@trask trask mentioned this pull request Jun 14, 2023
Merged
@trask trask mentioned this pull request Jul 25, 2023
Open
@jsuereth
Copy link
Contributor

jsuereth commented Aug 2, 2023

This needs to be updated for merge conflicts and I'd suggest thinking about the rename from runtime.process.jvm => jvm prior to this PR.

@trask
Copy link
Member Author

trask commented Aug 2, 2023

I'd suggest thinking about the rename from runtime.process.jvm => jvm prior to this PR.

I'm very supportive of this rename. I opened #227 to track.

@trask trask requested a review from a team August 13, 2023 23:46
@trask trask changed the title Rename process.runtime.jvm.classes.current_loaded to process.runtime.jvm.classes.count Rename jvm.classes.current_loaded to jvm.classes.count Aug 13, 2023
@trask
Copy link
Member Author

trask commented Aug 16, 2023

@open-telemetry/specs-semconv-maintainers this is ready to merge

@jsuereth jsuereth merged commit 3bd1c39 into open-telemetry:main Aug 16, 2023
8 checks passed
@trask trask deleted the rename-classes-current-loaded branch October 28, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@donbourne donbourne donbourne approved these changes

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees

@reyang reyang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trask @jsuereth @joaopgrassi @donbourne @reyang @jack-berg @mateuszrzeszutek