Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deprecated property instead of stability level #588

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Dec 7, 2023

Fixes #582

Merge requirement checklist

@lmolkova lmolkova requested review from a team December 7, 2023 03:44
model/registry/deprecated/http.yaml Outdated Show resolved Hide resolved
model/registry/deprecated/network.yaml Outdated Show resolved Hide resolved
model/registry/deprecated/network.yaml Outdated Show resolved Hide resolved
model/registry/deprecated/network.yaml Outdated Show resolved Hide resolved
model/registry/deprecated/http.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the deprecated-property branch from aaa5cc9 to 2b29d7a Compare December 13, 2023 18:13
@trask
Copy link
Member

trask commented Dec 13, 2023

(I moved this to "Ready to be Merged", would probably be nice to get it into upcoming release)

@reyang reyang merged commit bef6b4b into open-telemetry:main Dec 13, 2023
9 checks passed
@marcalff
Copy link
Member

@lmolkova

Please clarify if this causes a breaking change or not in the templates used to generate code.

In C++ for example, we use:

{%- if (attribute.stability | string()) == "StabilityLevel.DEPRECATED" %}

in here:

What should that code fragment change to, once new semantic conventions are used ?

@lmolkova
Copy link
Contributor Author

lmolkova commented Dec 15, 2023

@lmolkova

Please clarify if this causes a breaking change or not in the templates used to generate code.

In C++ for example, we use:

{%- if (attribute.stability | string()) == "StabilityLevel.DEPRECATED" %}

in here:

What should that code fragment change to, once new semantic conventions are used ?

yes, you're right it does cause breaking change on the jinja template side :(
Scratch that, until open-telemetry/build-tools#244 is merged and you start using the new version, this change has no effect on the tooling (which considers deprecated: descrioption and stability: deprecated to be equivalent).

Still, I'd recommend changing jinja template to do {%- if attribute.deprecated %} when updating to the upcoming version of semconv to prevent future issues.

pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Disambiguate attribute deprecation
6 participants