Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[model/resource] Change host.cpu.model.family and host.cpu.model.id to be strings #499

Merged
merged 4 commits into from
Nov 13, 2023
Merged

[model/resource] Change host.cpu.model.family and host.cpu.model.id to be strings #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d2bc36
[model/resource] Change `host.cpu.model.family` and `host.cpu.model.i…
mx-psi Nov 9, 2023
1383947
Merge branch 'main' into main
joaopgrassi Nov 10, 2023
1d36cf9
Merge branch 'main' into mx-psi/cpu-model-fam
mx-psi Nov 13, 2023
a90b0bd
Fix merge
mx-psi Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ release.

- Update `jvm.gc.duration` histogram buckets to `[ 0.01, 0.1, 1, 10 ]`
([#317](https://github.com/open-telemetry/semantic-conventions/pull/317))
- BREAKING: Change type of `host.cpu.model.id` and `host.cpu.model.family` to string.
([#495](https://github.com/open-telemetry/semantic-conventions/issues/495))

### Features

Expand Down
4 changes: 2 additions & 2 deletions docs/resource/host.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ To report host metrics, the `system.*` namespace SHOULD be used.
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| `host.cpu.cache.l2.size` | int | The amount of level 2 memory cache available to the processor (in Bytes). | `12288000` | Opt-In |
| `host.cpu.family` | int | Numeric value specifying the family or generation of the CPU. | `6` | Opt-In |
| `host.cpu.model.id` | int | Model identifier. It provides more granular information about the CPU, distinguishing it from other CPUs within the same family. | `6` | Opt-In |
| `host.cpu.family` | string | Family or generation of the CPU. | `6`; `PA-RISC 1.1e` | Opt-In |
AlexanderWert marked this conversation as resolved.
Show resolved Hide resolved
| `host.cpu.model.id` | string | Model identifier. It provides more granular information about the CPU, distinguishing it from other CPUs within the same family. | `6`; `9000/778/B180L` | Opt-In |
AlexanderWert marked this conversation as resolved.
Show resolved Hide resolved
| `host.cpu.model.name` | string | Model designation of the processor. | `11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz` | Opt-In |
| `host.cpu.stepping` | int | Stepping or core revisions. | `1` | Opt-In |
| `host.cpu.vendor.id` | string | Processor manufacturer identifier. A maximum 12-character string. [1] | `GenuineIntel` | Opt-In |
Expand Down
10 changes: 5 additions & 5 deletions model/resource/host.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,17 +106,17 @@ groups:
examples: [ 'GenuineIntel' ]
- id: family
requirement_level: opt_in
type: int
type: string
brief: >
Numeric value specifying the family or generation of the CPU.
examples: [ 6 ]
Family or generation of the CPU.
examples: [ '6', 'PA-RISC 1.1e' ]
- id: model.id
requirement_level: opt_in
type: int
type: string
brief: >
Model identifier. It provides more granular information about the CPU, distinguishing it from
other CPUs within the same family.
examples: [ 6 ]
examples: [ '6', '9000/778/B180L' ]
- id: model.name
requirement_level: opt_in
type: string
Expand Down
Loading