Clarify that client.port is the port of whichever client was captured in client.address
#471
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in client.address
trask
force-pushed
the
client-port-clarification
branch
from
5c3b9e1 to
911aa7e
Compare
AlexanderWert
approved these changes
Oct 29, 2023
mateuszrzeszutek
approved these changes
Oct 30, 2023
joaopgrassi
approved these changes
Oct 30, 2023
lmolkova
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Clarifies that
client.portis the port of whichever client was captured inclient.address.To avoid the situation where
X-Forwarded-Forhas no port, andclient.addressis captured fromX-Forwarded-Forandclient.portis captured from immediate peer.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.