Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the precedence between :authority and Host headers when populating server.address and server.port attributes #455

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Change the precedence between :authority and Host headers when populating server.address and server.port attributes #455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
246d42e
Change precedence between :authority and Host headers
trask Oct 26, 2023
fe1f4ea
Update CHANGELOG.md
trask Oct 27, 2023
1b184dd
Merge branch 'main' into reorder
joaopgrassi Oct 27, 2023
3be2281
Merge branch 'main' into reorder
joaopgrassi Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ release.
([#413](https://github.com/open-telemetry/semantic-conventions/pull/413))
- Clarify HTTP server definitions and `server.address|port` notes.
([#423](https://github.com/open-telemetry/semantic-conventions/pull/423))
- Change pthe recedence between `:authority` and `Host` headers when populating
trask marked this conversation as resolved.
Show resolved Hide resolved
`server.address` and `server.port` attributes.
([#455](https://github.com/open-telemetry/semantic-conventions/pull/455))

## v1.22.0 (2023-10-12)

Expand Down
2 changes: 1 addition & 1 deletion docs/http/http-spans.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,8 @@ In the context of HTTP server, `server.address` and `server.port` attributes cap
HTTP server instrumentations SHOULD do the best effort when populating `server.address` and `server.port` attributes and SHOULD determine them by using the first of the following that applies:

* The original host which may be passed by the reverse proxy in the [`Forwarded#host`][Forwarded], [`X-Forwarded-Host`][X-Forwarded-Host], or a similar header.
* The [`Host`][Host header] header.
* The [`:authority`][HTTP/2 authority] pseudo-header in case of HTTP/2 or HTTP/3
* The [`Host`][Host header] header.

> **Note**: The `Host` and `:authority` headers contain host and port number of the server. The same applies to the `host` identifier of `Forwarded` header or the `X-Forwarded-Host` header. Instrumentations SHOULD populate both `server.address` and `server.port` attributes by parsing the value of corresponding header.

Expand Down
Loading