Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move url to the registry #400

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Conversation

trisch-me
Copy link
Contributor

@trisch-me trisch-me commented Oct 12, 2023

Changes

Moving url to the new registry. No new code, only refactoring of the existing structure.

Merge requirement checklist

@trisch-me trisch-me requested review from a team October 12, 2023 19:51
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trisch-me trisch-me force-pushed the url-registry branch 3 times, most recently from c9ff0e4 to 031d0f1 Compare October 17, 2023 12:54
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the paths changes all come from re-running the semconv tool, right?

docs/url/url.md Show resolved Hide resolved
@trisch-me
Copy link
Contributor Author

yes, path changes are coming from running make table-generation

@joaopgrassi joaopgrassi merged commit a09cbef into open-telemetry:main Oct 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants