-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mobile crash data model spec #362
Add mobile crash data model spec #362
Conversation
cc @open-telemetry/semconv-mobile-approvers |
…ithub.com/tonzhan2/semantic-conventions into develop/add-data-model-for-mobile-crashes
Co-authored-by: jason plumb <[email protected]>
Co-authored-by: jason plumb <[email protected]>
Co-authored-by: jason plumb <[email protected]>
Co-authored-by: Surbhi A <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Alexander Wert <[email protected]>
Will do. |
…del-for-mobile-crashes
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
CC @marandaneto |
brief: > | ||
The contents from PLCrashReporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be possible to make the reporter agnostic?
In case I use KSCrash, I'd like to use the very same data model.
Maybe introducing a new property that tells what's the reporter format, such as KSCrash
, PLCrashReporter
or anything else.
- ref: ios.state | ||
requirement_level: | ||
recommended: If the crash occurred on an iOS device. | ||
- ref: android.state | ||
requirement_level: | ||
recommended: If the crash occurred on an Android device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should just call it state
and allow the OS name to be set such as ios
or android
, at least is flexible enough in case a new OS appears rather than introducing attributes for every OS.
- ref: ios.state | ||
requirement_level: | ||
recommended: If the crash occurred on an iOS device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ios
is specifically for iPhone, macOS
is for MacBook and friends.
Maybe we call it apple
instead? since the crash reports share the same format on all Apple platforms.
type: event | ||
brief: > | ||
This document defines attributes for crashes represented using Log Record Events. | ||
`event.domain` is 'device' and `event.name` is 'crash'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
event.name
should allow something different than crash
- or make it more generic.
crash
means the application exited, but this format should allow swallowed errors - but captured as well which is technically not a crash
but rather an error/exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current thinking is that we will model a separate event type for non-fatal errors/exceptions. There is already an event type called exception
in the spec but that's more for span events, that is, errors occuring in the context of a span, but we will need to model a similar event for a more generic usecase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to make that a different event type? the only difference between a crash and an error is its severity, the metadata is 100% the same.
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Tentative draft for mobile crashes reflected as standalone event logs. Not sure if added in the right place, and a little unfamiliar with formatting so any input is appreciated