-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit HTTP request method cardinality: use one attribute (option C/E) #35
Limit HTTP request method cardinality: use one attribute (option C/E) #35
Conversation
discussed at the Spec SIG meeting. Doing dim-capping for metrics on the same attribute or defining different semantics for signals blocks cross-signal joins and goes against OTel vision. |
6dfe368
to
0bc6fee
Compare
I'd be in favor of still normalizing the "http method" portion of the span name if we go with this option (i.e. producing same span names as Option A) |
I think that would defeat part of the purpose of this option. Ok, maybe not of the purpose, but if the assumption behind this option is that backends can cope with high cardinality of these things, I don't think the span name should get special treatment? |
This would need another (tracing-only) hint API/common processor. How critical do you think it is? If I had a magic wand, I'd rather ask users to provide low-cardinality names similar to server-side like "GET /container/{c}/blob/{b}" and I would design hint API around this |
I think the assumption behind this option is that there will be a new metric hint (#68) that will solve it (and will not pass on high cardinality to the backend) |
It's not clear to me how critical low-cardinality span names are. I thought the intention of making span names low-cardinality was to allow metrics to be produced with span name as a dimension, which I think would give it the same importance as having low-cardinality metric dimensions. |
hm, what would be the point, if all the components of a span name are already on the HTTP span as individual attributes? Let me create an issue in the spec repo on it. |
72532e9
to
cf0cc05
Compare
I've opened open-telemetry/opentelemetry-specification#3545 to work through what the metric advice would need to look like to make this option a reality, and to discuss whether it can address the "correlation problem" which has been the main (only?) objection to this option. |
closing in favor of #17 based on open-telemetry/opentelemetry-specification#3470 (comment) |
Option C/E from #17 :
Pros:
__DIMENSION_CAP
or another magic string consistent for all attributes value)Trade-offs:
__DIMENSION_CAP
magic string to a query likenot in(methods_used_on_metrics_set)
. Or there could be another backend solution to the query-by-capped-method-across-signals problem