-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding os.build_id resource attribute and discussion why os.sdk.version isn't required #293
Adding os.build_id resource attribute and discussion why os.sdk.version isn't required #293
Conversation
…from before done by make markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, adapt the PR title to reflect the fact only os.build
is being added.
I thought of it but wanted to keep it so others can benefit from the discussion. I updated it to reflect what exactly it covers. |
Co-authored-by: Joao Grassi <joao@joaograssi.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
@jsuereth This is my first PR in this repo and I'm not sure if I'm missing any last steps here. Is there anything I need to do next to get this pull request merged? I did resolve conflicts in changelog.md previously but I guess that'll keep happening everyday until this PR is merged. I'm not sure if I should do that everyday? |
Note: I've preserved the conversation as it went and not editing my this comment. But the only change done in this PR was adding os.build_id resource attribute. And we discussed in detail why os.sdk.version is not required to be in os.yaml
##Changes
Following changes have been done in os.yaml and os.md
Rationale behind the proposal:
os.build
Currently, os.version is available to add the complete version number along with build numbers. As the syntax of build numbers is different across different platforms it becomes difficult to parse the os.version attribute to extract the build number. Also for platforms like android where there can be multiple different manufacturers, build numbers can be defined differently. Google has also changed it's syntax for android build numbers from what it was earlier.
In last two week's client sig meetings where there was representation from the following platforms - Browser, iOS and Android, it was brought up, discussed and consensus was reached on the requirement of a separate attribute os.build to capture the build number.
Right now, iOS and Android are getting by this concern by adding build numbers to the os.description field:
IOS example: “iOS Version 16.4 (Build 20E247)”
Android example:
os.sdk_version
Additionally, there is no attribute to identify the SDK version (set of development tools & APIs used for development). It's not always 1 to 1 with the version number and is required to troubleshoot issues. Example - As seen here in android version number 12 can be associated with both API level 31 & 32.
Other things on the PR:
Merge requirement checklist