-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update span name recommendation for HTTP Server #287
Conversation
I am not sure if this is correct, and might conflict with #270 Should I just remove this line from here? |
@gouthamve Please rebase to make the checks pass. |
Signed-off-by: Goutham <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
I don't fully get the change here, I guess I'm missing some context here. |
It's not about not using the route anymore. How to set the span name is clearly defined in a dedicated section of this document:
The paragraph to remove in this PR suggested that the span name should be set just to |
@pyohannes Thanks! Now I get it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @gouthamve!
and thx @pyohannes for the explainer!
@open-telemetry/specs-semconv-maintainers I think this is good to merge |
This is to bring it inline with: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-server-semantic-conventions
Merge requirement checklist