Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jvm.buffer.(usage|limit) to jvm.buffer.memory.(usage|limit) #253

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

trask
Copy link
Member

@trask trask commented Aug 14, 2023

Fixes open-telemetry/opentelemetry-specification#3483

This helps clarify the difference with jvm.buffer.count which is the number of buffers.

Changes

Rename jvm.buffer.usage to jvm.buffer.memory.usage and rename jvm.buffer.limit to jvm.buffer.memory.limit.

Merge requirement checklist

@trask trask force-pushed the qualify-jvm-buffer-usage-and-limit branch from e5f31e2 to 19046c5 Compare August 14, 2023 21:30
@trask trask force-pushed the qualify-jvm-buffer-usage-and-limit branch from 19046c5 to 233a798 Compare August 14, 2023 21:31
@trask trask marked this pull request as ready for review August 14, 2023 21:31
@trask trask requested review from a team August 14, 2023 21:31
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@arminru arminru merged commit a42aecc into open-telemetry:main Aug 17, 2023
@trask trask deleted the qualify-jvm-buffer-usage-and-limit branch October 14, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename process.runtime.jvm.buffer.* metrics
7 participants