Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update destination attribute briefs #243

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

trask
Copy link
Member

@trask trask commented Aug 9, 2023

Based on @Oberon00's #206 (comment)

  • destination.address: "Peer address, for example IP address or UNIX socket name." (why does it use the removed term "peer" here? That would mean something rather different, and would match our old remote/local concept)

@trask trask requested review from a team August 9, 2023 22:28
@Oberon00
Copy link
Member

Theoretically this could need a changelog entry (breaking change)

@reyang reyang merged commit 313092c into open-telemetry:main Aug 10, 2023
@trask trask deleted the update-destination-attr-briefs branch August 10, 2023 17:00
rapphil pushed a commit to rapphil/semantic-conventions that referenced this pull request Aug 14, 2023
ChrsMark pushed a commit to ChrsMark/semantic-conventions that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants