Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template #223

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Add PR template #223

merged 6 commits into from
Aug 1, 2023

Conversation

reyang
Copy link
Member

@reyang reyang commented Jul 31, 2023

As discussed in the meeting today.

I'll create the tag once this PR got merged.

@reyang reyang requested review from a team July 31, 2023 23:53
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first start.

We may want to point folks at how to collect expert groups and kick of new areas in semconv as well.

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@reyang reyang merged commit ea17e33 into open-telemetry:main Aug 1, 2023
@reyang reyang deleted the reyang/pr-template branch August 1, 2023 16:21
bryce-b pushed a commit to bryce-b/semantic-conventions that referenced this pull request Aug 8, 2023
rapphil pushed a commit to rapphil/semantic-conventions that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants