Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uptime metrics for container, k8s Pod and k8s Node #1617

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Nov 26, 2024

Fixes #1486

Changes

This PR adds the container.uptime, k8s.pod.uptime and k8s.node.uptime metrics.
Existing implementation: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.114.0/receiver/kubeletstatsreceiver/documentation.md

These metrics are added following the discussions/decisions from:

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team as code owners November 26, 2024 11:28
@ChrsMark ChrsMark force-pushed the add_k8s_uptime_metrics branch from 35625f4 to 361146e Compare November 26, 2024 11:30
Copy link
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in terms of the expected semantics for uptime metrics.

@lmolkova lmolkova enabled auto-merge (squash) November 26, 2024 21:26
@lmolkova lmolkova merged commit 68629b9 into open-telemetry:main Nov 26, 2024
14 checks passed
@ChrsMark ChrsMark deleted the add_k8s_uptime_metrics branch November 26, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[k8s] Define semantic conventions for k8s uptime metrics
5 participants