Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in schemas for messaging attribute changes #1595

Merged

Conversation

JamieDanielson
Copy link
Member

@JamieDanielson JamieDanielson commented Nov 19, 2024

Changes

While reviewing recent semantic convention changes, I noticed these typos for messaging changes.

Merge requirement checklist

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lmolkova
Copy link
Contributor

lmolkova commented Nov 20, 2024

it seems we should not update old schemas -

> DO NOT add your changes to files inside the `schemas` folder. Always add your
> changes to the `schema-next.yaml` file.

I'd like to stop producing/updating these files manually - #1596.

Curious what brought your attention to these files, @JamieDanielson ? Do you happen to use them in any way?

@JamieDanielson
Copy link
Member Author

Curious what brought your attention to these files, @JamieDanielson ? Do you happen to use them in any way?

We were updating our semantic conventions package in JS and wanted to make sure we captured the breaking changes since we also recently updated our build script. I just happened to notice the typo in the 0.28 schema file and put up a PR to fix it. We don't use this attribute anywhere as far as I can tell.

schemas/1.27.0 Outdated Show resolved Hide resolved
@lmolkova lmolkova merged commit aca6d57 into open-telemetry:main Nov 26, 2024
14 checks passed
@JamieDanielson JamieDanielson deleted the jamie.fix-typo-messaging-schema branch November 26, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants