Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fixed a dead link for machine id man page #1584

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

gyliu513
Copy link
Member

Fixes #

Changes

This is fixing a CI error here https://github.com/open-telemetry/semantic-conventions/actions/runs/11861560247/job/33059139725?pr=1574

@lmolkova ^^

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@gyliu513 gyliu513 requested review from a team as code owners November 15, 2024 21:30
@gyliu513 gyliu513 changed the title Fixed a dead link for machine id man page [chore] Fixed a dead link for machine id man page Nov 15, 2024
@trask trask added the Skip Changelog Label to skip the changelog check label Nov 15, 2024
@trask
Copy link
Member

trask commented Nov 15, 2024

hi @gyliu513! it looks like you need to also update it in the yaml file

@gyliu513
Copy link
Member Author

@trask which yaml file you are mentioning, can you point that out? Thanks!

@trask
Copy link
Member

trask commented Nov 16, 2024

oh, looks like it's in 3 places: https://github.com/search?q=repo%3Aopen-telemetry%2Fsemantic-conventions+freedesktop&type=code

@gyliu513
Copy link
Member Author

@trask done, thanks!

@lmolkova lmolkova enabled auto-merge (squash) November 16, 2024 18:22
@lmolkova lmolkova merged commit c1a0a2d into open-telemetry:main Nov 16, 2024
14 checks passed
@gyliu513 gyliu513 deleted the dead-link branch November 17, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants