-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend GenAI system to support IBM Watsonx AI and AWS Bedrock #1574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@open-telemetry/semconv-genai-approvers please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@lmolkova do you know when this will be reflected to https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-semantic-conventions/src/opentelemetry/semconv/_incubating/attributes/gen_ai_attributes.py ? Thanks |
@gyliu513 we'll need to release the new version of semconvs first. We're due for release, but with KubeCon we got behind and it might take 1-2 weeks. Then someone (usually me, but can be anyone else) needs to regenerate code in https://github.com/open-telemetry/opentelemetry-python/tree/main/opentelemetry-semantic-conventions. |
Hi @gyliu513 @lmolkova , is there a convention for specifying GenAI attribute values or, more generally, in OpenTelemetry? For instance, |
@mxiamxia I think there is no standard for this yet, you may also see that vertex ai is using @lmolkova I think it will be great if we can keep consistent for all LLM platforms, like what is the recommended delimiter for the attribute values. |
Think about it as namespaces in the code. There could be a lot of different things in It took us a bit to come up with this rule of thumb, so you might see a lot of examples in the repo that don't follow this patter yet (or not worth breaking). Anyway, we try to follow this pattern for everything new. |
Thank you all for the response. AWS Observability team is working on supporting AWS Bedrock in CloudWatch by adhering to the OpenTelemetry LLM Spec. We will follow the aligned pattern and collaborate with you to contribute the relevant changes in OTel SDKs. |
*Description of changes:* Updating `gen_ai.system` attribute key to better align with upstream Otel conventions. Context: open-telemetry/semantic-conventions#1574 (comment) *Test plan:* Ran updated unit tests and contract tests. <img width="2560" alt="Screenshot 2024-12-16 at 9 57 36 AM" src="https://github.com/user-attachments/assets/8e5e7ff5-1608-417a-bc9d-cfb72de538b3" /> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
*Description of changes:* Updating `gen_ai.system` attribute key to better align with upstream Otel conventions. Context: open-telemetry/semantic-conventions#1574 (comment) *Test plan:* Ran updated unit tests and contract tests. <img width="2560" alt="Screenshot 2024-12-16 at 10 42 28 AM" src="https://github.com/user-attachments/assets/b0886292-5a99-4e90-87b0-4ee009a3553e" /> <img width="2560" alt="Screenshot 2024-12-16 at 10 58 38 AM" src="https://github.com/user-attachments/assets/4dab00d0-9141-43f5-980d-fdcd6924d69f" /> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --------- Co-authored-by: Min Xia <[email protected]>
Added IBM Watsonx AI and AWS Bedrock to the list of possible values that the
gen_ai.system
attribute can take.Changes
The following are added:
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]