Add enum value headers #1570
Closed
Add enum value headers #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add headers in order to separate enum value tables from the footnotes above. Fixes open-telemetry#1569
|
FYI - this one has poor interaction with TOC generation, which is a separate tool from table generation. You could update the makefile to run toc generation immediately after weaver table generation. |
|
@jsuereth seems like |
dyladan
commented
Nov 13, 2024
| @@ -17,6 +17,9 @@ and various HTTP versions like 1.1, 2 and SPDY. | |||
| - [Name](#name) | |||
| - [Status](#status) | |||
| - [HTTP client](#http-client) | |||
| - [`error.type` Values](#errortype-values) | |||
There was a problem hiding this comment.
@jsuereth I think this looks right
|
Maybe we can add something fancier later but I'd like to get separators of some kind in and the other PR seems easier at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add headers in order to separate enum value tables from the footnotes above.
Fixes #1569