Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on span status for databases #1560

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Nov 8, 2024

Addresses the DB part of #1536.

Let's polish it for databases and then expand to other conventions (and potentially have a generic guidance).

The intention is to keep exception event part experimental since

  • there doesn't seem to be a consensus or a common approach for it
  • span events is going away

Merge requirement checklist

@lmolkova lmolkova requested review from a team as code owners November 8, 2024 02:58
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
.chloggen/1560.yaml Outdated Show resolved Hide resolved
maryliag
maryliag previously approved these changes Nov 25, 2024
@lmolkova lmolkova force-pushed the database-span-status branch from 8a2a33c to a3d0677 Compare November 25, 2024 19:12
@lmolkova lmolkova requested a review from a team as a code owner November 25, 2024 19:12
@lmolkova lmolkova requested a review from maryliag November 26, 2024 02:33
@lmolkova lmolkova dismissed maryliag’s stale review November 26, 2024 02:33

testing codeowners

@lmolkova lmolkova enabled auto-merge (squash) November 26, 2024 20:49
@lmolkova lmolkova merged commit f49b5cd into open-telemetry:main Nov 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants