Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process.executable.build_id: rename attribute #1520

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

florianl
Copy link
Contributor

Changes

With open-telemetry/opentelemetry-specification#4197 it was decided to rename the attribute from process.executable.build_id.profiling to process.executable.build_id.htlhash (Head-Tail-Length Hash).

FYI @open-telemetry/profiling-maintainers

Merge requirement checklist

@florianl florianl requested review from a team as code owners October 28, 2024 07:45
@florianl florianl force-pushed the profiling-htlhash branch 3 times, most recently from 7d85188 to 40e4902 Compare October 28, 2024 07:52
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is this level of change tracking needed while we're still experimental?

@lmolkova lmolkova enabled auto-merge (squash) October 29, 2024 20:55
@lmolkova lmolkova merged commit 5261f96 into open-telemetry:main Oct 29, 2024
13 of 14 checks passed
florianl added a commit to open-telemetry/opentelemetry-ebpf-profiler that referenced this pull request Nov 12, 2024
With open-telemetry/semantic-conventions#1520
process.executable.build_id.profiling got renamed to
process.executable.build_id.htlhash.

Signed-off-by: Florian Lehner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants