Add network.interface.name attribute

[ChrsMark]

Changes

ref: #308 (comment)

As discussed in the above referenced issue, this PR introduces the network.interface.name attribute and replace with it the system.device attribute of system and container network metrics.

Note: I'm not sure if this change can be reflected in schema-next.yaml 🤔 .

Merge requirement checklist

• CONTRIBUTING.md guidelines followed.
• Change log entry added, according to the guidelines in When to add a changelog entry.
  • If your PR does not need a change log, start the PR title with [chore]
• schema-next.yaml updated with changes to existing conventions.

[joaopgrassi]

Note: I'm not sure if this change can be reflected in schema-next.yaml 🤔 .

It can, you can list the metrics that are affected and the attribute change. See for example: https://github.com/open-telemetry/semantic-conventions/blob/main/schemas/1.28.0#L48

[joaopgrassi]

Please also add the old attribute to the deprecated file, like https://github.com/open-telemetry/semantic-conventions/blob/main/model/database/deprecated/registry-deprecated.yaml

[ChrsMark]

Thank's @joaopgrassi . My concern here is that system.device is not entirely removed, it's still used as an attribute in other metrics. Here we just replace its usage in specific metrics. I guess this can be reflected in the schema-next as you mentioned, but should this also be added in the deprecated file(s)?

[joaopgrassi]

but should this also be added in the deprecated file(s)?

I believe yes, each "area" now has its own deprecated file, so within that usage, the attribute is considered deprecated. There then it's also mentioned which one to use instead.

@lmolkova @jsuereth is this correct in your view? Not sure if we had such case before 🤔

[ChrsMark]

but should this also be added in the deprecated file(s)?

I believe yes, each "area" now has its own deprecated file, so within that usage, the attribute is considered deprecated. There then it's also mentioned which one to use instead.

@lmolkova @jsuereth is this correct in your view? Not sure if we had such case before 🤔

Appears that we can't model this right now?

I get:

> make fix

Diagnostic report:

  × The attribute id `system.device` is declared multiple times in the
  │ following groups:
  │ ["registry.container.metrics.deprecated",
  │ "registry.system.metrics.deprecated", "registry.system"]

/cc @joaopgrassi

[lmolkova]

LGTM (with some minor suggestions to make CI happy)

[lmolkova]

Appears that we can't model this right now?

There is no need to deprecate attributes if it's still used.

The only thing you need to do is to write the proper section in the schema-next (which you already did!)

[ChrsMark]

@open-telemetry/semconv-system-approvers could you review this one please ?