Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove empty lines in generated markdown #1477

Merged

Conversation

joaopgrassi
Copy link
Member

Super nit PR. This improves the jinja templates a bit, so we don't have the extra empty lines in the generated markdown. I know, some real important work 😅but it was bothering me for a while.

Merge requirement checklist

@joaopgrassi joaopgrassi added editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. docs labels Oct 15, 2024
@joaopgrassi joaopgrassi requested review from a team and tigrannajaryan as code owners October 15, 2024 11:23
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW! Thank you!

@lmolkova lmolkova merged commit d5d2b9d into open-telemetry:main Oct 15, 2024
14 checks passed
@joaopgrassi joaopgrassi deleted the jinja-remove-emptylines branch October 16, 2024 07:35
ChrsMark pushed a commit to ChrsMark/semantic-conventions that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants