Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] uncomment device.app.lifecycle event definition #1461

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

MSNev
Copy link
Contributor

@MSNev MSNev commented Oct 9, 2024

Now that Semantic Conventions supports event yaml definitions, this PR is uncommenting the device.app.lifecycle event definition so that it is defined in yaml and ready for markdown generation.

Note: Once committed this will block anyone consuming the updated SemConv version that has not yet migrated to using weaver.

@MSNev MSNev changed the title chore: uncomment device.app.lifecycle event definition [chore]: uncomment device.app.lifecycle event definition Oct 9, 2024
@MSNev MSNev changed the title [chore]: uncomment device.app.lifecycle event definition [chore] uncomment device.app.lifecycle event definition Oct 9, 2024
@MSNev MSNev force-pushed the MSNev/DeviceEventYaml branch from 9fccb96 to d306d6e Compare October 9, 2024 16:21
@MSNev MSNev force-pushed the MSNev/DeviceEventYaml branch from d306d6e to ae55bc6 Compare October 9, 2024 16:25
@MSNev MSNev marked this pull request as ready for review October 9, 2024 16:28
@MSNev MSNev requested review from a team as code owners October 9, 2024 16:28
@joaopgrassi
Copy link
Member

Note: Once committed this will block anyone consuming the updated SemConv version that has not yet migrated to using weaver.

Then this cannot be merged, right? Because there are still SIGs that haven't yet migrated to Weaver: open-telemetry/weaver#227

@lmolkova
Copy link
Contributor

lmolkova commented Oct 10, 2024

@joaopgrassi that's a great point! I agree we should not add features that break build-tools until the migration is finished

I just checked if build-tools will fail on this change and it doesn't - lmolkova/opentelemetry-python#3

Build-tools has a mode to ignore validation errors - for this one it warns with [Warning] /source/device/events.yaml: Invalid keys: ['body'] - @12:5 ('device.app.lifecycle') (among other things it doesn't recognize like 'name' on resources).

As a result, nobody can generate event bodies with build-tools, but that's a new feature and nobody generated them in the past (and won't be able to).

BTW we still have a CI check - semantic-conventions-compatibility that runs build-tools in this mode and we can use it to see if new feature introduces any unrecoverable problems.

@lmolkova lmolkova merged commit 76112dd into open-telemetry:main Oct 14, 2024
14 checks passed
ChrsMark pushed a commit to ChrsMark/semantic-conventions that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants