Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing resource back compat checks #1459

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Oct 8, 2024

Back-compat checks are failing since 1.28.0 was released with

Violation: Resource 'service' cannot remove required/recommended attributes (missing '{"service.name", "service.version"}')
  - Category         : backward_compatibility
  - Type             : semconv_attribute
  - SemConv group    : service
  - SemConv attribute: 
  - Provenance: /home/weaver/source

Violation: Resource 'telemetry.sdk' cannot remove required/recommended attributes (missing '{"telemetry.sdk.language", "telemetry.sdk.name", "telemetry.sdk.version"}')
  - Category         : backward_compatibility
  - Type             : semconv_attribute
  - SemConv group    : telemetry.sdk
  - SemConv attribute: 
  - Provenance: /home/weaver/source

E.g. here #1454

It happens because we marked service and telemetry.sdk groups as stable, but there are two groups with the same name and they are being compared against each other.

This is being fixed in #1423, in the meantime we need to compare stable groups.

@lmolkova lmolkova added tooling Regarding build, workflows, build-tools, ... Skip Changelog Label to skip the changelog check labels Oct 8, 2024
@lmolkova lmolkova requested review from a team as code owners October 8, 2024 23:20
@lmolkova lmolkova changed the title Resource back compat check workaround Fix failing resource back compat checks Oct 8, 2024
@joaopgrassi joaopgrassi merged commit a9fe0c6 into open-telemetry:main Oct 9, 2024
15 checks passed
ChrsMark pushed a commit to ChrsMark/semantic-conventions that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check tooling Regarding build, workflows, build-tools, ...
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants