Recommend making create spans disableable #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Oct 3, 2024
lmolkova
commented
Oct 3, 2024
carlosalberto
approved these changes
Oct 3, 2024
lmolkova
force-pushed
the
messaging-make-create-spans-disableable
branch
from
e5ff1e3 to
a0ddae4
Compare
joaopgrassi
approved these changes
Oct 7, 2024
3 tasks
Co-authored-by: Joao Grassi <[email protected]>
ChrsMark
pushed a commit
to ChrsMark/semantic-conventions
that referenced
this pull request
Oct 18, 2024
Co-authored-by: Joao Grassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1273
Changes
Provides guidance on when to create "Create" spans (when instrumenting batch-send) and recommends allowing to disable "Create" spans for batching operations.
Merge requirement checklist
[chore]