feat!: Update GraphQL span name convention #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to concerns about high cardinality with the current span name format use only the <graphql.operation.type> attribute for the span name. The higher cardinality attribute, <graphql.operation.name> can still be used in queries, as it is an attribute on the span. The original fallback, "GraphQL Operation" is preserved.
kaylareopelle
commented
Sep 4, 2024
This was referenced Sep 4, 2024
lmolkova
reviewed
Sep 4, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
kaylareopelle
commented
Oct 7, 2024
Provide an path for a config option to add
{graphql.operation.name} to the span name, but with a clear warning around high cardinality.
…emantic-conventions into update-graphql-span-name
|
It seems like the wayback machine is down at the moment, causing the markdown-link-check job to fail: https://github.com/open-telemetry/semantic-conventions/actions/runs/11263374842/job/31321102055?pr=1389#step:4:10 |
joaopgrassi
approved these changes
Oct 10, 2024
ChrsMark
pushed a commit
to ChrsMark/semantic-conventions
that referenced
this pull request
Oct 18, 2024
Co-authored-by: Joao Grassi <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1361
Changes
Due to concerns about high cardinality with the current span name format, use only the
graphql.operation.typeattribute for the span name. The higher cardinality attribute,graphql.operation.namecan still be used in queries, as it is an attribute on the span. The original fallback span name,GraphQL Operation, is preserved.Merge requirement checklist
[chore]