Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated Java example #1378

Merged

Conversation

johantiden
Copy link
Contributor

@johantiden johantiden commented Sep 2, 2024

Fixes #1375

Changes

Change deprecated Java example Thread.currentThread().getId() to Thread.currentThread().threadId()

Merge requirement checklist

…entThread().getId() to Thread.currentThread().threadId()
Copy link

linux-foundation-easycla bot commented Sep 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: AlexanderWert / name: Alexander Wert (edd79e8)
  • ✅ login: johantiden / name: Johan Tidén (1118a22)

@johantiden
Copy link
Contributor Author

I read the CONTRIBUTING.md but it's unclear if I need to compile anything since I edited directly into an .md file.

@johantiden johantiden marked this pull request as ready for review September 2, 2024 19:22
@johantiden johantiden requested review from a team September 2, 2024 19:22
@lmolkova
Copy link
Contributor

lmolkova commented Sep 3, 2024

thanks for updating it @johantiden!

I read the CONTRIBUTING.md but it's unclear if I need to compile anything since I edited directly into an .md file.

The markdown you changed is hand-written, so no need to re-generate anything

@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label Sep 3, 2024
@AlexanderWert AlexanderWert merged commit c492cce into open-telemetry:main Sep 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

General thread attributes - Java's Thread.currentThread().getId() is deprecated
3 participants