Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

describe JVM CPU metrics #13

Merged
merged 4 commits into from
May 16, 2023
Merged

describe JVM CPU metrics #13

merged 4 commits into from
May 16, 2023

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger requested review from a team May 12, 2023 13:36
@jack-berg
Copy link
Member

Should run make table-generation to regenerate the markdown tables. @jsuereth should the build fail if this step hasn't been completed?

@Oberon00
Copy link
Member

Checks did complete successfully: https://github.com/open-telemetry/semantic-conventions/actions/runs/4959486530/jobs/8873655841?pr=13

Is there a reference to this from markdown anywhere? Probably there should be?

@jack-berg
Copy link
Member

Ah interesting. It looks like note field on attributes manifests as footnotes but nothing happens with the note field on metrics. Ignore my comment for this PR - this appears to be an enhancement needed for build-tools.

@Oberon00
Copy link
Member

Yes, it might be related to #1086

jsuereth
jsuereth approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I think we'll need to bump the semconv tooling to get this to show up in the future, but orthogonal to the fix.

Thanks for submitting!

@jsuereth
Copy link
Contributor

@zeitlinger would you mind adding to changelog? Then we can merge

@zeitlinger zeitlinger force-pushed the jvm_cpu_description branch from 8200e2b to 5112209 Compare May 16, 2023 12:11
@zeitlinger zeitlinger requested a review from a team May 16, 2023 12:11
@zeitlinger
Copy link
Member Author

@zeitlinger would you mind adding to changelog? Then we can merge

done

@jsuereth jsuereth merged commit 3a0a2d9 into open-telemetry:main May 16, 2023
@joaopgrassi joaopgrassi mentioned this pull request May 30, 2023
Merged
@zeitlinger zeitlinger deleted the jvm_cpu_description branch June 27, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@mx-psi mx-psi mx-psi approved these changes

@trask trask trask approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@jsuereth jsuereth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zeitlinger @jack-berg @Oberon00 @jsuereth @trask @mx-psi @reyang