Db metrics pending requests #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @open-telemetry/semconv-db-approvers |
lmolkova
approved these changes
Jul 31, 2024
gregkalapos
reviewed
Aug 2, 2024
gregkalapos
approved these changes
Aug 5, 2024
trask
approved these changes
Aug 12, 2024
ezimuel
pushed a commit
to ezimuel/semantic-conventions
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Liudmila Molkova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
During the prototype for the DB Metrics, found that is not always possible to have a cumulative value. Having just a current value makes more sense. Existing implementations of this metric are already using the current or are using a wrong implementation of the cumulative.
Merge requirement checklist
[chore]