Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudEvents should re-use existing HTTP or messaging conventions #1182

Merged

Conversation

joaopgrassi
Copy link
Member

@joaopgrassi joaopgrassi commented Jun 26, 2024

Fixes #654

Changes

We are approaching the stability of the messaging conventions, and as discussed we want to clarify the relation between CloudEvents convention with messaging. The conclusion we have is that applications/instrumentations working with CloudEvents should generally follow either the HTTP conventions or messaging. Those already offer mechanisms for context propagation and also are prepared to handle asynchronous scenarios such as when CloudEvents are sent via messaging systems.

Merge requirement checklist

@joaopgrassi joaopgrassi marked this pull request as ready for review June 28, 2024 09:25
@joaopgrassi joaopgrassi requested review from a team June 28, 2024 09:25
docs/cloudevents/cloudevents-spans.md Outdated Show resolved Hide resolved
docs/cloudevents/cloudevents-spans.md Outdated Show resolved Hide resolved
docs/cloudevents/cloudevents-spans.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to make this too complicated, so as long as we avoid duplication with messaging semantic conventions (which the current approach already does), I'm happy to approve this.

Just one additional remark below.

docs/cloudevents/cloudevents-spans.md Outdated Show resolved Hide resolved
@joaopgrassi
Copy link
Member Author

@lmolkova @pyohannes I took your suggestions and also from the discussions in the CloudEvents PR and tried to simplify things a bit. Would be great if you can take another look. Thanks!

@lmolkova lmolkova enabled auto-merge (squash) July 15, 2024 16:13
@lmolkova lmolkova merged commit 02ecf0c into open-telemetry:main Jul 16, 2024
12 checks passed
@joaopgrassi joaopgrassi deleted the cloud-events-restructure branch July 16, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Clarify possible incompatibilities with CloudEvents Distributed Tracing extension
4 participants