remove k8s.container.status.current_waiting_reason resource attribute #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
approved these changes
Jun 3, 2024
joaopgrassi
reviewed
Jun 3, 2024
lmolkova
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Note: attribute definitions are not related to a signal. I.e. this attribute can still be used, just not as a resource attribute.
If the only use case for it was to be used as a resource attribute, then yes, it's best to remove it before it was released and re-introduce if it's ever needed.
povilasv
force-pushed
the
revert-k8s-waiting-status
branch
from
a609a74 to
99284a1
Compare
joaopgrassi
approved these changes
Jun 4, 2024
heyams
pushed a commit
to heyams/semantic-conventions
that referenced
this pull request
Jun 11, 2024
heyams
pushed a commit
to heyams/semantic-conventions
that referenced
this pull request
Jun 11, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #997 due to immutability constraint.
Ref #997