Add LLM model server metrics #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
reviewed
Jun 3, 2024
|
cc @jsuereth to take a look as well |
drewby
reviewed
Jun 13, 2024
gyliu513
reviewed
Jun 19, 2024
This change adds common model server metrics that we want to standardize on. It starts of with two common latency metrics - time per output token and time to first token.
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
achandrasekar
force-pushed
the
model-server-metrics
branch
from
4036f71 to
2873d9f
Compare
drewby
requested changes
Jun 21, 2024
lmolkova
reviewed
Jun 21, 2024
lmolkova
reviewed
Jun 21, 2024
Co-authored-by: Drew Robbins <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]>
lmolkova
approved these changes
Jun 21, 2024
joaopgrassi
approved these changes
Jun 26, 2024
jsuereth
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds common model server metrics that we want to standardize on. It starts of with two common latency metrics - time per output token and time to first token.
Fixes #1102
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
This change adds common model server metrics that we want to standardize on. It starts of with two common latency metrics - time per output token and time to first token.
Merge requirement checklist
[chore]