-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GenAI instead of LLM and other clean ups #1087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm trying to understand this change, particularly it came from @drewby who had this at the end of the issue
What I noticed was that LLM was pretty much if not completely stripped from the docs. In most cases replacing it with GenAI or GenAI model. Assuming the wildcard is correct (there's no attribute that is only about LLM and not also GenAI in general), it may still help to introduce the topic a bit better on the span or metric docs. for example, change "A request to an Generative AI is modeled as a span in a trace." to "A request to a Generative AI system is modeled as a span in a trace. For example, this could be an LLM or image generation prompt" I'm not sure the exact language, but hopefully this gets the point across. I like generalizing, but also it would be nice to know if anything was accidentally wildcarded from LLM to GenAI and also if we can keep the word "LLM" somewhere to help contextualize the spec. I'm happy to raise a PR if folks agree on what should happen here. |
Fix #969
With #811 merged, we now have inconsistent LLM vs GenAI usage. This PR:
[chore]