Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: we're allowing to use existing attribute name as a namespace #1067

Closed
wants to merge 1 commit into from
Closed

Bug: we're allowing to use existing attribute name as a namespace #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/attributes-registry/log.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@

This document defines log attributes

| Attribute | Type | Description | Examples | Stability |
| -------------- | ------ | ------------------------------------------------------------------------------ | ------------------ | ---------------------------------------------------------------- |
| `log.iostream` | string | The stream associated with the log. See below for a list of well-known values. | `stdout`; `stderr` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| Attribute | Type | Description | Examples | Stability |
| ------------------ | ------ | ------------------------------------------------------------------------------ | ------------------ | ---------------------------------------------------------------- |
| `log.iostream` | string | The stream associated with the log. See below for a list of well-known values. | `stdout`; `stderr` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
| `log.iostream.foo` | string | Should not be allowed | `bar` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |

`log.iostream` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used.

Expand Down
5 changes: 5 additions & 0 deletions model/registry/log.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ groups:
value: 'stderr'
brief: 'Events from stderr stream'
stability: experimental
- id: iostream.foo
stability: experimental
brief: Should not be allowed
type: string
examples: [ "bar" ]

- id: registry.log.file # TODO: should we move it to the file model?
type: attribute_group
Expand Down
Loading