Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in standard unit for http and rpc request duration #868

Open
sivadeepN opened this issue Apr 1, 2024 · 1 comment
Open

Difference in standard unit for http and rpc request duration #868

sivadeepN opened this issue Apr 1, 2024 · 1 comment
Assignees

Comments

@sivadeepN
Copy link

What are you trying to achieve?

Trying to standardize metrics across our organization according to OpenTelemetry (OTel) conventions. I noticed that the standard unit for HTTP duration is in seconds (s), while that of RPC is in milliseconds (ms). I need to understand the rationale behind this difference in convention.

What did you expect to see?

Additional context.

I came across a pull request (PR) that addresses the issue for HTTP duration, changing it from milliseconds to seconds. However, I'm uncertain why RPC metrics have a different unit.

rpc.server.duration Histogram ms Measures the duration of inbound RPC. [1]

http.server.request.duration Histogram s Duration of HTTP server requests. [1]

@pyohannes
Copy link
Contributor

This issue belongs to https://github.com/open-telemetry/semantic-conventions, it is a duplicate of #383.

Currently, implementations emit RPC metrics in milliseconds, so changing semantic conventions would be a breaking change for those implementation. We plan to do those changes once we work on stabilizing RPC semantic conventions.

@trask trask transferred this issue from open-telemetry/opentelemetry-specification Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants