Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use seconds as default duration for RPC metrics #383

Open
pyohannes opened this issue Oct 11, 2023 · 0 comments
Open

Use seconds as default duration for RPC metrics #383

pyohannes opened this issue Oct 11, 2023 · 0 comments
Assignees

Comments

@pyohannes
Copy link
Contributor

pyohannes commented Oct 11, 2023

This issue was created based on a discussion about #176.

General guidelines for metric instrumentation units require that for measuring durations, seconds should be used:

  • When instruments are measuring durations, seconds (i.e. s) SHOULD be used.

However, the following FaaS metrics still use milliseconds for measuring durations:

For consistency, those histograms should be changed to use seconds. Those metrics are already in use, and to avoid unnecessary disruptions the change should happen during stabilization of RPC semantic conventions and should be covered by the OTEL_SEMCONV_STABILITY_OPT_IN mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants