-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s.pod.ip
attribute
#1160
Comments
@open-telemetry/semconv-k8s-approvers @jsuereth @tigrannajaryan please take a look |
The name and location seem right to me. We've been using this field as a resource attribute for many many years and had no issues. |
Regarding mutability we have a bunch other attributes that are mutable as you point out ( |
The concept of mutable attributes fits well with the upcoming concept of Entities. We plan to reflect this in the semconv in the future. |
So, this is essentially blocked by the entity initiative? |
We don't need to block it. We can add it as an experimental k8s Resource attribute. We may have to change it later depending on entities SIG work, but that's expected for experimental attributes. Resource attributes are de-facto mutable today in the data model, from recipient's perspective. The SDK says they are immutable, but that is not guaranteed or enforced in any way between SDK restarts. The current reading of the spec should be "Resource attributes don't change during the lifetime of one SDK run". |
@joaopgrassi I think you meant #918 :), right? |
Yes 😅 thanks! |
Area(s)
area:k8s
Is your change request related to a problem? Please describe.
The
k8s.pod.ip
is already used by the Collector for the association of Pod's signals with the respective Pod's metadata.With open-telemetry/opentelemetry-collector-contrib#33440 the Collector will provide the option to explicitly expose this as an additional attribute as well.
Describe the solution you'd like
We would like to define a Semantic Convention to cover the
k8s.pod.ip
attribute.Describe alternatives you've considered
No response
Additional context
One thing to consider here is that Pod's IP can change during Pod's existence. An interesting discussion/summary around this can be found at kubernetes/kubernetes#108281 (comment).
Having said this, the
k8s.pod.ip
will be mutable so it can't be a resource attribute similarly to the current status of a container discussed at #997 (comment).However I wonder if this constraint is valid for all the Resource cases we want to cover in SemConv, and I think it is already violated in the
k8s.pod.{label,annotation}.*
case where a label or annotation can be overwritten.(same for host's IPs, I guess)
@open-telemetry/specs-semconv-approvers I would love your thoughts here.
The text was updated successfully, but these errors were encountered: