Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort enum members in the md table alphabetically #1082

Closed
lmolkova opened this issue May 28, 2024 · 1 comment · Fixed by #1083
Closed

Sort enum members in the md table alphabetically #1082

lmolkova opened this issue May 28, 2024 · 1 comment · Fixed by #1083
Assignees
@reyang
Labels
area:other bug Something isn't working good first issue Good for newcomers triage:needs-triage

Comments

@lmolkova
Copy link
Contributor

lmolkova commented May 28, 2024 •
edited
Loading

We render enum members table in the same order as members appear in yaml, but should instead render alphabetically

See #1077
@lmolkova lmolkova added bug Something isn't working triage:needs-triage labels May 28, 2024
@lmolkova lmolkova changed the title Sort enum values alphabetically Sort enum members in the md table alphabetically May 28, 2024
@lmolkova
Copy link
Contributor Author

I believe it can be done by changing the enum template in this repo, no weaver change should be necessary.

trisch-me added a commit to trisch-me/semantic-conventions that referenced this issue May 28, 2024
@trisch-me
fix open-telemetry#1082; sort enums members in table
1ae6440
@trisch-me trisch-me mentioned this issue May 28, 2024
Merged
3 tasks
@jsuereth jsuereth moved this to Template Generation Fixes in Semantic Conventions Tooling May 28, 2024
@jsuereth jsuereth added the good first issue Good for newcomers label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyang reyang

Labels
area:other bug Something isn't working good first issue Good for newcomers triage:needs-triage
Projects
Semantic Conventions Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] sort enums members in table trisch-me/semantic-conventions
3 participants
@jsuereth @lmolkova @reyang