Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copies of metric-requirement-level and attribute-requirement-level from semconv repository. #10

Closed
jsuereth opened this issue May 11, 2023 · 1 comment · Fixed by #47
Assignees

Comments

@jsuereth
Copy link
Contributor

See: #5 (comment)

TL;DR: we are currently soft-linking to requirement levels for attributes/metrics defined by the specification.

  • These should become deep links to the specification
  • We need more automation around updating the specification version
  • The version semconv relies on (1.21) has not been released yet.

This is an issue to remind us to clean this up once semconv 1.21 is released and we can link to stable versions.

Related see #9

@jsuereth
Copy link
Contributor Author

Note: Here is the error message when trying to link against 1.20 of specification:

  [✖] https://github.com/open-telemetry/opentelemetry-specification/tree/1.20.0/specification/common/attribute-naming.md → Status: 404
  [✖] https://github.com/open-telemetry/opentelemetry-specification/tree/1.20.0/specification/common/attribute-requirement-level.md → Status: 404
  [✖] https://github.com/open-telemetry/opentelemetry-specification/tree/1.20.0/specification/metrics/metric-requirement-level.md → Status: 404

jsuereth added a commit to jsuereth/semantic-conventions that referenced this issue May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant