Skip to content

Commit

Permalink
changelog and nits
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed Nov 19, 2024
1 parent 5636fd0 commit e73c30c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
4 changes: 4 additions & 0 deletions .chloggen/1560.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
change_type: enhancement
component: db
note: Specify how to set span kind for database operations.
issues: [1536, 1560]
9 changes: 4 additions & 5 deletions docs/database/database-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ Instrumentation SHOULD consider the operation as failed if any of the following
- the `db.response.status_code` value indicates an error

> [!NOTE]
>
> The classification of status code as an error depends on the context.
> For example, a SQL STATE `02000` (`no_data`) indicates an error when the application
> expected the data to be available. However, it is not an error when the
Expand Down Expand Up @@ -133,10 +132,10 @@ span being recorded is a local root span (does not have a local parent).

> [!NOTE]
> Exception stack traces could be very long and are expensive to capture and store.
> Exceptions which are not handled by instrumented libraries are likely to be caught,
> logged, and handled by the caller.
> Exceptions that are not handled will be recorded by the outermost (local root) instrumentation
> such as HTTP or gRPC server.
> Exceptions which are not handled by instrumented libraries are likely to be handled
> and logged by the caller.
> Exceptions that are not handled will be recorded by the outermost (local root)
> instrumentation such as HTTP or gRPC server.
## Common attributes

Expand Down

0 comments on commit e73c30c

Please sign in to comment.