Skip to content

Commit

Permalink
Clarify that service.* conventions apply to all telemetry sources (#630)
Browse files Browse the repository at this point in the history
Co-authored-by: Joao Grassi <[email protected]>
  • Loading branch information
jack-berg and joaopgrassi authored Jan 10, 2024
1 parent 73b488a commit 7f35c49
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ release.

### Fixes

- Clarify that `service.*` attributes apply to all telemetry sources.
([#630](https://github.com/open-telemetry/semantic-conventions/pull/630))

## v1.24.0 (2023-12-15)

### Breaking
Expand Down
4 changes: 2 additions & 2 deletions docs/resource/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ as specified in the [Resource SDK specification](https://github.com/open-telemet

**type:** `service`

**Description:** A service instance.
**Description:** A telemetry source. OpenTelemetry has adopted a broad interpretation such that every telemetry source is a service. Examples include, but are not limited to: web services, hosts, mobile applications, browser application, edge computing devices, functions as a service, databases, message brokers, etc. Specific types of telemetry sources may have additional conventions defining domain specific information, but the `service` conventions are applicable to all telemetry sources.

<!-- semconv service -->
| Attribute | Type | Description | Examples | Requirement Level |
Expand All @@ -94,7 +94,7 @@ as specified in the [Resource SDK specification](https://github.com/open-telemet

**type:** `service`

**Description:** Additions to service instance.
**Description:** Experimental additions to service.

<!-- semconv service_experimental -->
| Attribute | Type | Description | Examples | Requirement Level |
Expand Down
7 changes: 6 additions & 1 deletion model/resource/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ groups:
prefix: service
type: resource
brief: >
A service instance.
A telemetry source. OpenTelemetry has adopted a broad interpretation such that every
telemetry source is a service. Examples include, but are not limited to: web services,
hosts, mobile applications, browser application, edge computing devices, functions as
a service, databases, message brokers, etc. Specific types of telemetry sources may have
additional conventions defining domain specific information, but the `service`
conventions are applicable to all telemetry sources.
attributes:
- id: name
type: string
Expand Down
2 changes: 1 addition & 1 deletion model/resource/service_experimental.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ groups:
prefix: service
type: resource
brief: >
A service instance.
Experimental additions to service.
attributes:
- id: namespace
type: string
Expand Down

0 comments on commit 7f35c49

Please sign in to comment.