move to common cross-signal attribute

open-telemetry · Apr 4, 2024 · 73845d0 · 73845d0
1 parent 934722a
commit 73845d0
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/docs/messaging/messaging-metrics.md b/docs/messaging/messaging-metrics.md
@@ -35,9 +35,9 @@ All messaging metrics share the same set of attributes:
 | [`messaging.system`](../attributes-registry/messaging.md) | string | An identifier for the messaging system being used. See below for a list of well-known identifiers. | `activemq` | `Required` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | [`error.type`](../attributes-registry/error.md) | string | Describes a class of error the operation ended with. [1] | `amqp:decode-error`; `KAFKA_STORAGE_ERROR`; `channel-error` | `Conditionally Required` [2] | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
 | [`messaging.destination.name`](../attributes-registry/messaging.md) | string | The message destination name [3] | `MyQueue`; `MyTopic` | `Conditionally Required` [4] | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
-| [`messaging.destination.partition.id`](../attributes-registry/messaging.md) | string | The identifier of the partition messages are sent to or received from, unique within the `messaging.destination.name`. | `1` | `Conditionally Required` if available. | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | [`messaging.destination.template`](../attributes-registry/messaging.md) | string | Low cardinality representation of the messaging destination name [5] | `/customers/{customerId}` | `Conditionally Required` if available. | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | [`server.address`](../attributes-registry/server.md) | string | Server domain name if available without reverse DNS lookup; otherwise, IP address or Unix domain socket name. [6] | `example.com`; `10.1.2.80`; `/tmp/my.sock` | `Conditionally Required` If available. | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
+| [`messaging.destination.partition.id`](../attributes-registry/messaging.md) | string | The identifier of the partition messages are sent to or received from, unique within the `messaging.destination.name`. | `1` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | [`server.port`](../attributes-registry/server.md) | int | Server port number. [7] | `80`; `8080`; `443` | `Recommended` | ![Stable](https://img.shields.io/badge/-stable-lightgreen) |
 
 **[1]:** The `error.type` SHOULD be predictable and SHOULD have low cardinality.

diff --git a/model/messaging-common.yaml b/model/messaging-common.yaml
@@ -6,6 +6,7 @@ groups:
     attributes:
       - ref: messaging.system
         requirement_level: required
+      - ref: messaging.destination.partition.id
       - ref: error.type
         examples: ['amqp:decode-error', 'KAFKA_STORAGE_ERROR', 'channel-error']
         requirement_level:

diff --git a/model/metrics/messaging.yaml b/model/metrics/messaging.yaml
@@ -11,10 +11,6 @@ groups:
       - ref: messaging.destination.template
         requirement_level:
           conditionally_required: if available.
-      - ref: messaging.destination.partition.id
-        requirement_level:
-          conditionally_required: if available.
-
 
   # durations
   - id: metric.messaging.publish.duration