oops

open-telemetry · Apr 18, 2024 · 68ec7e2 · 68ec7e2
1 parent eb1b1fa
commit 68ec7e2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/docs/attributes-registry/messaging.md b/docs/attributes-registry/messaging.md
@@ -175,8 +175,8 @@ size should be used.
 <!-- semconv registry.messaging.deprecated(omit_requirement_level) -->
 | Attribute  | Type | Description  | Examples  | Stability |
 |---|---|---|---|---|
-| `kafka.consumer.group` | string | Deprecated, use `messaging.consumer.group.name` instead. | `my-group` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `messaging.consumer.group.name`. |
+| `messaging.kafka.consumer.group` | string | Deprecated, use `messaging.consumer.group.name` instead. | `my-group` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `messaging.consumer.group.name`. |
 | `messaging.kafka.destination.partition` | int | Deprecated, use `messaging.destination.partition.id` instead. | `2` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `messaging.destination.partition.id`. |
 | `messaging.operation` | string | Deprecated, use `messaging.operation.type` instead. | `publish`; `create`; `process` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `messaging.operation.type`. |
-| `rocketmq.client_group` | string | Deprecated, use `messaging.consumer.group.name` instead. | `myConsumerGroup` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `messaging.consumer.group.name` on the consumer spans. No replacement for producer spans. |
+| `messaging.rocketmq.client_group` | string | Deprecated, use `messaging.consumer.group.name` instead. | `myConsumerGroup` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `messaging.consumer.group.name` on the consumer spans. No replacement for producer spans. |
 <!-- endsemconv -->
diff --git a/model/registry/deprecated/messaging.yaml b/model/registry/deprecated/messaging.yaml
@@ -18,15 +18,15 @@ groups:
           Deprecated, use `messaging.operation.type` instead.
         examples: ["publish", "create", "process"]
         deprecated: "Replaced by `messaging.operation.type`."
-      - id: kafka.consumer.group
+      - id: messaging.kafka.consumer.group
         type: string
         brief: >
           Deprecated, use `messaging.consumer.group.name` instead.
         deprecated: >
           Replaced by `messaging.consumer.group.name`.
         stability: experimental
         examples: 'my-group'
-      - id: rocketmq.client_group
+      - id: messaging.rocketmq.client_group
         type: string
         brief: >
           Deprecated, use `messaging.consumer.group.name` instead.

diff --git a/schema-next.yaml b/schema-next.yaml
@@ -10,7 +10,11 @@ versions:
               state: db.client.connections.state
             apply_to_metrics:
               - db.client.connections.usage
-        # TODO
+        # https://github.com/open-telemetry/semantic-conventions/pull/815
+        - rename_attributes:
+            attribute_map:
+              messaging.kafka.destination.partition: messaging.destination.partition.id
+        # https://github.com/open-telemetry/semantic-conventions/pull/815
         - rename_attributes:
             attribute_map:
               messaging.kafka.consumer.group: messaging.consumer.group.name