Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold propagation in trace state #235

Merged
merged 39 commits into from
Jan 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
3502d8b
First draft of threshold propagation proposal
kentquirk Aug 9, 2023
0369c35
Respond to feedback.
kentquirk Aug 31, 2023
8c84f4d
appease linter
kentquirk Aug 31, 2023
e8e0496
One more linty list
kentquirk Aug 31, 2023
23b0bea
Respond to feedback
kentquirk Sep 6, 2023
6866873
Remove embedded question.
kentquirk Sep 6, 2023
f3fc7c2
sampled flag
kentquirk Sep 6, 2023
5a9e0d9
lint
kentquirk Sep 6, 2023
38654af
More feedback
kentquirk Sep 13, 2023
de457b1
Explain common algorithms
kentquirk Sep 14, 2023
5e43b9b
Incorporate further feedback
kentquirk Sep 28, 2023
ac0b11c
fix lint errors
kentquirk Oct 4, 2023
12aa163
Update with image
kentquirk Oct 4, 2023
4698ae5
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Oct 5, 2023
5ad5630
respond to some feedback
kentquirk Oct 12, 2023
5217916
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Oct 12, 2023
65b9a7b
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Nov 30, 2023
66bc0d2
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Nov 30, 2023
a0b4bf0
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Nov 30, 2023
bbdf1af
Fix adjusted count language
kentquirk Nov 30, 2023
84077b5
Appease the linter
kentquirk Nov 30, 2023
106aa2d
Cmon, lint. Tell me all the problems at once!
kentquirk Nov 30, 2023
9d2c5e9
Try to convert to rejection threshold
kentquirk Jan 11, 2024
fb119a2
Merge branch 'main' into threshold-propagation
kentquirk Jan 11, 2024
e699133
Incorporate Peter's comments
kentquirk Jan 17, 2024
eb55ac5
incorporate Peter's comments
kentquirk Jan 17, 2024
56094a0
explain rejection threshold
kentquirk Jan 17, 2024
a4fb718
linters, amirite?
kentquirk Jan 17, 2024
e3367ac
Update graphic
kentquirk Jan 17, 2024
8504a99
Remove extra paren
kentquirk Jan 18, 2024
108bca5
update graphic to Josh's latest
kentquirk Jan 19, 2024
50d105f
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Jan 25, 2024
4d262b4
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Jan 25, 2024
91af1f4
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Jan 25, 2024
29e322b
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Jan 25, 2024
dcda3c1
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Jan 25, 2024
e790133
respond to feedback
kentquirk Jan 25, 2024
88bcd53
Update text/trace/0235-sampling-threshold-in-trace-state.md
kentquirk Jan 25, 2024
053df85
Merge branch 'main' into threshold-propagation
kentquirk Jan 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions text/trace/0235-sampling-threshold-in-trace-state.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
# Sampling Threshold Propagation in TraceState

## Motivation
kentquirk marked this conversation as resolved.
Show resolved Hide resolved

Sampling can theoretically take place at nearly any point in a distributed tracing system. If sampling is to be performed at multiple points in the process, the only way to reason about it effectively is to make sure that the sampling decisions are **consistent**. In this context consistency is the property that allows different points in the sampling chain to make the same sampling decisions, based on information included with the trace.
kentquirk marked this conversation as resolved.
Show resolved Hide resolved

kentquirk marked this conversation as resolved.
Show resolved Hide resolved
## Explanation

The existing, experimental [specification for probability sampling using TraceState](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/tracestate-probability-sampling.md) is limited to powers-of-two probabilities, and is designed to work without making assumptions about TraceID randomness.
This system can only achieve non-power-of-two sampling using interpolation between powers of two, which is unnecessarily restrictive.
In existing sampling systems, sampling probabilities like 1%, 10%, and 75% are common, and it should be possible to express these without interpolation.
There is also a need for consistent sampling in the collection path (outside of the head-sampling paths) and using inherent randomness in the traceID is a less-expensive solution than referencing a custom `r-value` from the tracestate in every span.
This proposal allows for the continued expression of randomness using `r-value` as specified there using the key `r`.
However, that value is limited to powers of two, while this proposal is not; to distinguish the cases, this proposal uses the key `rv`.


In order to make consistent sampling decisions across the entire path of the trace, two values SHOULD be propagated with the trace:

1. A random (or pseudo-random) value of at least 56 bits, called `R` below.
kentquirk marked this conversation as resolved.
Show resolved Hide resolved
2. A 56-bit trace threshold as expressed in the TraceState, called `T` below.
kentquirk marked this conversation as resolved.
Show resolved Hide resolved

The sampling decision is propagated with the following algorithm:
* If the `th` key is not specified, then no previous sampling decision has been made.
* If the value of the `th` key is `!`, always sample.
* Else parse the `th` key as a hex value as described below.
* Compare the 56 bits of `T` with the 56 bits of `R`. If `T <= R`, then do not sample.
kentquirk marked this conversation as resolved.
Show resolved Hide resolved
* This implies that if `T` is 0, then never sample.

The `R` value MUST be derived as follows:
* If the Random Trace ID Flag is `true` in the traceparent header, then `R` is the lowest-order 56 bits of the trace-id.
* Else if the key `rv` is present in the Tracestate header, then `R = rv`.
kentquirk marked this conversation as resolved.
Show resolved Hide resolved
* Else if the key `r` is present in the Tracestate header, then `R = 2**(56-r)`.
kentquirk marked this conversation as resolved.
Show resolved Hide resolved
* Else `R` should be generated as a random value in the range `(0, (2**56)-1)` and added to the Tracestate header with key `rv`.
kentquirk marked this conversation as resolved.
Show resolved Hide resolved

The preferred way to propagate this value is as the lowest 56 bits of the trace-id. If these bits are in fact random, the `random` trace-flag SHOULD be set as specified in [the W3C trace context specification](https://w3c.github.io/trace-context/#trace-id).

The value of the `rv` and `th` keys MUST be expressed as up to 14 hexadecimal characters from the set `[0-9a-f]`. Trailing zeros (but not leading zeros) may be omitted. _Question: should we permit [A-F] as well, or instead?_

kentquirk marked this conversation as resolved.
Show resolved Hide resolved
Examples:
`th=!` -- "Always Sample".
kentquirk marked this conversation as resolved.
Show resolved Hide resolved
`th=8` -- equivalent to `th=80000000000000`, which is 50% probability.
`th=08` -- equivalent to `th=08000000000000`, which is 3.125% probability.
`th=0` -- equivalent to `th=00000000000000`, which means "Never Sample".

The `T` value MUST be derived as follows:
* If the `th` key is not present in the Tracestate header, then `T` is effectively 2^56 (which doesn't fit in 56 bits).
* Else the value corresponding to the `th` key should be interpreted as above.


Sampling Decisions, once made, SHOULD be propagated by setting the value of the `th` key in the Tracestate header according to the above.

In the case of a downstream sampler that is attempting to reduce the volume of traffic, the sampler MAY modify the `th` header.

kentquirk marked this conversation as resolved.
Show resolved Hide resolved
A sampler MAY introduce an R value to a trace that does not include one. It SHOULD use `rv` for this purpose. A sampler MAY NOT modify an existing R value or trace-id.

kentquirk marked this conversation as resolved.
Show resolved Hide resolved
## Internal details

The trace state header SHOULD contain a field with the key `rv`, and a value that corresponds to a 56-bit sampling threshold.
This value will be compared to the 56-bit random value associated with the trace.

kentquirk marked this conversation as resolved.
Show resolved Hide resolved
From a technical perspective, how do you propose accomplishing the proposal? In particular, please explain:

* How the change would impact and interact with existing functionality
* Likely error modes (and how to handle them)
* Corner cases (and how to handle them)

While you do not need to prescribe a particular implementation - indeed, OTEPs should be about **behaviour**, not implementation! - it may be useful to provide at least one suggestion as to how the proposal *could* be implemented. This helps reassure reviewers that implementation is at least possible, and often helps them inspire them to think more deeply about trade-offs, alternatives, etc.
kentquirk marked this conversation as resolved.
Show resolved Hide resolved

## Trade-offs and mitigations

This proposal is the result of long negotiations on the Sampling SIG over what is required and various alternative forms of expressing it. [This issue](https://github.com/open-telemetry/opentelemetry-specification/issues/3602) exhaustively covers the various formats that were discussed and their pros and cons. This proposal is the result of that decision.

## Prior art and alternatives

The existing specification for `r-value` and `p-value` attempted to solve this problem, but were limited to powers of 2, which is inadequate.

## Open questions

This specification leaves room for different implementation options. For example, comparing hex strings or converting them to numeric format are both viable alternatives for handling the threshold.

We also know that some implementations prefer to use a sampling probability (in the range from 0-1.0) or a sampling rate (1/probability); this design permits conversion to and from these formats without loss up to at least 6 decimal digits of precision.

## Future possibilities

This permits sampling systems to propagate consistent sampling information downstream where it can be compensated for. For example, this will enable the tail-sampling processor in the OTel Collector to propagate its sampling decisions to backends in a standard way.
kentquirk marked this conversation as resolved.
Show resolved Hide resolved