-
Notifications
You must be signed in to change notification settings - Fork 164
Propose OpenTelemetry Profiling Vision #212
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, thank you.
Approving, this is aligned with my vision as well.
Co-authored-by: Tigran Najaryan <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
+1 NB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a couple of minor wording fixes from the performance section I added in the original doc.
Overall LGTM - I'm a little curious about the initial implementation and its target languages (it seems that it has been informally established the effort will start with Go and Java profiling?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits, otherwise LGTM!
This captures the vision and spirit of the discussions over the past few months, and is a good position from which to start this collaborative effort. I support! +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decent statement of high-level intent.
Co-authored-by: Sean Heelan <[email protected]>
Co-authored-by: Sean Heelan <[email protected]>
If I had to make it more concrete - I might adopt the Rust targets for OS/libc/CPU as a first approximation - especially for embedded CPUs. On a geospatial level - lat/long would be useful data for network flow modeling. Also network triangulation like pings to three servers - bandwidth might be harder to measure. |
I believe all comments have been addressed let me know if anything else needs to be before merging! |
This vision now has a large number of approvals from existing OpenTelemetry members, from OpenTelemetry Technical Committee and Governance Committee and from the new Profiling Workgroup members. I believe this shows a clear alignment on the vision from all participants. Members of @open-telemetry/technical-committee if you haven't had a chance to review this vision, please do. I will merge the PR and will consider this current vision accepted by OpenTelemetry Profiling if I don't see any further comments. |
No new comments. Lots of approvals. Merging. |
This change proposes high-level items that define our long-term vision for Profiling support in OpenTelemetry project. A group of open source maintainers, vendors, end-users, and developers excited about profiling / otel have been meeting for ~8 weeks now and this document was created collectively in order to share with the broader community for feedback. We've had ~15 people contribute directly to the document and over 60 people who have attended our meetings over the past couple of months. This idea of "Adding profiling as a support event type" has also been discussed at length in [this issue](open-telemetry#139) created in October 2020. If this proposal is accepted/approved then we will proceed with filling out this [project tracking issue](open-telemetry/opentelemetry-specification#2731) and following the other procedures outlined in the [project management instructions](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/project-management.md). Comments, ideas, feedback, etc. are all very welcome and highly appreciated!
This change proposes high-level items that define our long-term vision for Profiling support in OpenTelemetry project. A group of open source maintainers, vendors, end-users, and developers excited about profiling / otel have been meeting for ~8 weeks now and this document was created collectively in order to share with the broader community for feedback. We've had ~15 people contribute directly to the document and over 60 people who have attended our meetings over the past couple of months. This idea of "Adding profiling as a support event type" has also been discussed at length in [this issue](open-telemetry#139) created in October 2020. If this proposal is accepted/approved then we will proceed with filling out this [project tracking issue](open-telemetry/opentelemetry-specification#2731) and following the other procedures outlined in the [project management instructions](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/project-management.md). Comments, ideas, feedback, etc. are all very welcome and highly appreciated!
This change proposes high-level items that define our long-term vision for Profiling support in OpenTelemetry project. A group of open source maintainers, vendors, end-users, and developers excited about profiling / otel have been meeting for ~8 weeks now and this document was created collectively in order to share with the broader community for feedback. We've had ~15 people contribute directly to the document and over 60 people who have attended our meetings over the past couple of months. This idea of "Adding profiling as a support event type" has also been discussed at length in [this issue](open-telemetry#139) created in October 2020. If this proposal is accepted/approved then we will proceed with filling out this [project tracking issue](open-telemetry/opentelemetry-specification#2731) and following the other procedures outlined in the [project management instructions](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/project-management.md). Comments, ideas, feedback, etc. are all very welcome and highly appreciated!
This change proposes high-level items that define our long-term vision for Profiling support in OpenTelemetry project. A group of open source maintainers, vendors, end-users, and developers excited about profiling / otel have been meeting for ~8 weeks now and this document was created collectively in order to share with the broader community for feedback. We've had ~15 people contribute directly to the document and over 60 people who have attended our meetings over the past couple of months. This idea of "Adding profiling as a support event type" has also been discussed at length in [this issue](open-telemetry/oteps#139) created in October 2020. If this proposal is accepted/approved then we will proceed with filling out this [project tracking issue](#2731) and following the other procedures outlined in the [project management instructions](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/project-management.md). Comments, ideas, feedback, etc. are all very welcome and highly appreciated!
This change proposes high-level items that define our long-term vision for
Profiling support in OpenTelemetry project.
A group of open source maintainers, vendors, end-users, and developers excited about profiling / otel have been meeting for ~8 weeks now and this document was created collectively in order to share with the broader community for feedback. We've had ~15 people contribute directly to the document and over 60 people who have attended our meetings over the past couple of months.
This idea of "Adding profiling as a support event type" has also been discussed at length in this issue created in October 2020.
If this proposal is accepted/approved then we will proceed with filling out this project tracking issue and following the other procedures outlined in the project management instructions.
Comments, ideas, feedback, etc. are all very welcome and highly appreciated!