Support per-Tracer configuration through Tracer Provider #186
Conversation
| @@ -0,0 +1,124 @@ | |||
| # Per Tracer Configuration | |||
|
|
|||
| Support setting configuration (Sampler, IdGenerator, Span Limits, etc) on | |||
There was a problem hiding this comment.
Could you give an exhaustive list of configuration to be shared? Or is it any kind of configuration, including processors exporters, and resources?
There was a problem hiding this comment.
It is any configuration. But I don't believe that includes the resource? The resource is part of the Provider but it isn't a configuration value passed by the user when building a Provider, right?
I used etc because it should cover any future additional configuration added to the Tracer Provider.
I left out explicitly including Span Processors because it is a bit of a pain point I cover later in the OTEP, but I could add it back to the list just to be complete.
And the Exporter is configured as part of the Processor so it is based on if those are configurable or not.
| configurations. Most existing implementations do not offer the | ||
| capability of creating multiple Tracer Providers and may essentially prohibit | ||
| it. Allowing configuration to be done through the Tracer Provider based on the |
There was a problem hiding this comment.
Is this true? I don't recall anything in the spec that would lead to implementations that are incapable of supporting multiple tracer providers. While multiple providers do present the issue noted below WRT sharing exporters, I think that any problem caused by sharing exporters can be solved without new specification (i.e., treated as implementation details).
There was a problem hiding this comment.
There isn't anything in the spec that would necessarily lead to it. Some, like Java, support multiple providers only through having multiple SDKs.
I don't think leaving how exporters are shared up to each implementation would be a nice user experience, and definitely not lead to consistent support.
|
Closed at @tsloughter's request :) |
Support setting configuration (Sampler, IdGenerator, Span Limits, etc) on individual Tracers that overrides the shared configuration provided by the Tracer Provider.