-
Notifications
You must be signed in to change notification settings - Fork 164
Add status to RFC template #17
Add status to RFC template #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,5 +1,7 @@ | |||
# Replace this with your awesome RFC title | |||
|
|||
**Status:** `proposed` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we enumerate all the possible values? Maybe: draft
, in-progress
, approved
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely.
My thinking had been that proposed
made sense for the template since that's the starting state.
Also, the possible states are enumerates here: https://github.com/open-telemetry/rfcs#the-rfc-life-cycle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add an italicized comment w/ the URL spelled out, for reviewing the lifecycle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I did not see all the definitions there. Looks good.
@@ -1,5 +1,7 @@ | |||
# Replace this with your awesome RFC title | |||
|
|||
**Status:** `proposed` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I did not see all the definitions there. Looks good.
* Copy OC specs into specification dir * Copy OT spec into specification/README.md * Remove work-in-progress files * Move specification/ into work_in_progress/
No description provided.