Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

HTTP/JSON Encoded for OTLP #122

Merged
merged 4 commits into from
Jul 7, 2020

Conversation

tensorchen
Copy link
Member

@tensorchen tensorchen commented Jun 27, 2020

Protobuf is a relatively big dependency, which some clients are not willing to take. For example, webjs, iOS/Android (in some scenarios, the size of the installation package is limited, do not want to introduce protobuf dependencies). Plain JSON is a smaller dependency and is built in the standard libraries of many programming languages.

This OTEP will be consistent with the OTEP0099(OTLP/HTTP) specification except that the payload will use JSON instead of protobuf.

@tensorchen
Copy link
Member Author

@open-telemetry/specs-approvers please review.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, left a couple comments.

The protocol details are a copy of OTEP0099 with appropriate replacements to use JSON instead of ProtoBuf. I believe it is the right approach to make this full copy of the text and amend the text instead of posting just the amendments in this OTEP. The full copy is more readable.

text/0000-otlp-http-json.md Outdated Show resolved Hide resolved
text/0000-otlp-http-json.md Outdated Show resolved Hide resolved
text/0000-otlp-http-json.md Outdated Show resolved Hide resolved
@carlosalberto
Copy link
Contributor

Hey @tensorchen

The (brand new, still undocumented) flow for OTEPS is to first create an issue in https://github.com/open-telemetry/opentelemetry-specification, discuss whether it's a breaking/polemical change, and

a) If it's a relatively straightforward change, work directly in the Specification repo to reflect the proposed changes.
b) If it is indeed deemed as change that needs an OTEP, discuss it here (as you did).

Would you mind creating an issue for this in https://github.com/open-telemetry/opentelemetry-specification so we discuss it there (and we possibly later re-take this OTEP)? Since you already wrote this proposal, you can mention it in such issue ;)

Thanks in advance!

@bogdandrutu
Copy link
Member

@open-telemetry/specs-approvers please make sure you review this :)

@bogdandrutu bogdandrutu requested a review from a team July 7, 2020 23:24
@bogdandrutu bogdandrutu merged commit b2385e3 into open-telemetry:master Jul 7, 2020
@tensorchen tensorchen deleted the otlp-http-json branch June 8, 2021 07:06
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
* Add HTTP+JSON support for OTLP

* update protocol detail desc

* Rename title, handle line-breaking

Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
* Add HTTP+JSON support for OTLP

* update protocol detail desc

* Rename title, handle line-breaking

Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 30, 2024
* Add HTTP+JSON support for OTLP

* update protocol detail desc

* Rename title, handle line-breaking

Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Nov 8, 2024
* Add HTTP+JSON support for OTLP

* update protocol detail desc

* Rename title, handle line-breaking

Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants