-
Notifications
You must be signed in to change notification settings - Fork 164
Conversation
@open-telemetry/specs-approvers please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, left a couple comments.
The protocol details are a copy of OTEP0099 with appropriate replacements to use JSON instead of ProtoBuf. I believe it is the right approach to make this full copy of the text and amend the text instead of posting just the amendments in this OTEP. The full copy is more readable.
Hey @tensorchen The (brand new, still undocumented) flow for OTEPS is to first create an issue in https://github.com/open-telemetry/opentelemetry-specification, discuss whether it's a breaking/polemical change, and a) If it's a relatively straightforward change, work directly in the Specification repo to reflect the proposed changes. Would you mind creating an issue for this in https://github.com/open-telemetry/opentelemetry-specification so we discuss it there (and we possibly later re-take this OTEP)? Since you already wrote this proposal, you can mention it in such issue ;) Thanks in advance! |
@open-telemetry/specs-approvers please make sure you review this :) |
* Add HTTP+JSON support for OTLP * update protocol detail desc * Rename title, handle line-breaking Co-authored-by: Bogdan Drutu <[email protected]>
* Add HTTP+JSON support for OTLP * update protocol detail desc * Rename title, handle line-breaking Co-authored-by: Bogdan Drutu <[email protected]>
* Add HTTP+JSON support for OTLP * update protocol detail desc * Rename title, handle line-breaking Co-authored-by: Bogdan Drutu <[email protected]>
* Add HTTP+JSON support for OTLP * update protocol detail desc * Rename title, handle line-breaking Co-authored-by: Bogdan Drutu <[email protected]>
Protobuf is a relatively big dependency, which some clients are not willing to take. For example, webjs, iOS/Android (in some scenarios, the size of the installation package is limited, do not want to introduce protobuf dependencies). Plain JSON is a smaller dependency and is built in the standard libraries of many programming languages.
This OTEP will be consistent with the OTEP0099(OTLP/HTTP) specification except that the payload will use JSON instead of protobuf.