Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to reflect the Mission+Vision work #848

Closed
wants to merge 1 commit into from
Closed

Conversation

bhs
Copy link
Contributor

@bhs bhs commented Oct 20, 2021

Basically three things:

  • OTel is a telemetry project, not an observability project. Let's be clearer about that.
  • Change the tagline to align well to the Mission
  • Link to the Mission+Vision prominently (and adjust other links accordingly)

cc @open-telemetry/governance-committee

Basically three things:
- OTel is a telemetry project, not an observability project. Let's be
  clearer about that.
- Change the tagline to align well to the Mission
- Link to the Mission+Vision prominently (and adjust other links
  accordingly)
@bhs bhs requested a review from a team October 20, 2021 04:11
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the Get started buttons link to getting-started pages. I'd propose leaving Learn more at the top. I'll add a screenshot below.

@chalin
Copy link
Contributor

chalin commented Oct 20, 2021

@bhs - I'd propose this adjustment to your change:

Thoughts? If you're agreeable to this change, I can push the edit onto this PR. Let me know.

@chalin
Copy link
Contributor

chalin commented Oct 20, 2021

Also, it would be preferable (IMHO) to have the Mission and vision page hosted on this website -- we want the website to be the focal point of all things OTel: users get a better experience if they aren't push off to other resources (like GH pages). But we can address this point separately.

@bhs
Copy link
Contributor Author

bhs commented Oct 20, 2021

@chalin thanks for your feedback. Re this:

All of the Get started buttons link to getting-started pages. I'd propose leaving Learn more at the top. I'll add a screenshot below.

I actually tried this myself. IMO the "Learn More" is a bit of a misnomer, as it sends the visitor fairly deep into the weeds of terminology/glossary stuff rather than covering the high-level purpose of OpenTelemetry. This is why I renamed the "Learn More" button as "Key Concepts" in this change.

As for your comment about a prettier and "website-native" Mission+Vision+Values page: sounds fine to me, though I will admit that I don't really understand how to build a net new page here... maybe I could file an issue to track this going forward?

@chalin
Copy link
Contributor

chalin commented Oct 20, 2021

This is why I renamed the "Learn More" button as "Key Concepts" in this change.

I'm ok with the button title Key concepts. With this new button title, are you ok with the edit I gave a screenshot of earlier?

As for your comment about a prettier and "website-native" Mission+Vision+Values page: sounds fine to me, though I will admit that I don't really understand how to build a net new page here... maybe I could file an issue to track this going forward?

Yes, please.

@bhs
Copy link
Contributor Author

bhs commented Oct 20, 2021

@chalin

I'm ok with the button title Key concepts. With this new button title, are you ok with the edit I gave a screenshot of earlier?

I also tried that permutation earlier / pre-PR. I don't feel super strongly about it, but the "Key Concepts" page seems very much like a Get started! sort of thing. So why push it above / near the Mission+Vision link?

@chalin
Copy link
Contributor

chalin commented Oct 20, 2021

I also tried that permutation earlier / pre-PR. I don't feel super strongly about it, but the "Key Concepts" page seems very much like a Get started! sort of thing. So why push it above / near the Mission+Vision link?

Here's how I see it, based on my experience working on other tech doc sites:

  • Get[ting] started (or Quick start) pages are where a reader goes to "jump in" and get something running. It's like going to the car dealer and first giving a car a test run before considering anything else. So these pages are expected to be hands on.
  • Learn more is where a reader goes to (as the title implies) learn more about the product. That button currently links to docs/concepts, whose description is What is OpenTelemetry, what does it provide and what does it support?. That seems perfectly reasonable to me.

Let me know how you'd like to proceed. Thanks.

@bhs
Copy link
Contributor Author

bhs commented Oct 20, 2021

@chalin thanks – I will raise this at the OTel GC meeting tomorrow to see if there's a consensus there. I don't have super strong feelings about this so just want to get a few more opinions before we commit in one direction or the other.

@chalin
Copy link
Contributor

chalin commented Oct 21, 2021

I will raise this at the OTel GC meeting tomorrow

@bhs - great! Could you also raise #852?

@chalin chalin mentioned this pull request Oct 21, 2021
32 tasks
@chalin
Copy link
Contributor

chalin commented Oct 21, 2021

I will raise this at the OTel GC meeting tomorrow

Any feedback on this?

@bhs
Copy link
Contributor Author

bhs commented Oct 21, 2021

@chalin we had a packed agenda so I just mentioned that we hadn't reached consensus and that additional feedback would be welcome today. If we don't get any, I'm inclined to make the change you suggested and merge this.

@chalin
Copy link
Contributor

chalin commented Oct 21, 2021

... If we don't get any, I'm inclined to make the change you suggested and merge this.

Sounds good. I've already made the change locally, so give me a sign and I'll push the delta into this PR.

@bhs
Copy link
Contributor Author

bhs commented Oct 22, 2021

@chalin since nobody weighed in, can you please push your change to the PR? Thanks.

@chalin
Copy link
Contributor

chalin commented Oct 22, 2021

You seem to have created this PR from a fork's branch, so I can't seem to push my changes. I went ahead and created #856. PTAL

@chalin
Copy link
Contributor

chalin commented Oct 22, 2021

Closed by #856

@chalin chalin closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants