Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java docs #844

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 19, 2021

@chalin chalin requested review from jkwatson and a team October 19, 2021 18:45
@chalin chalin force-pushed the chalin-java-docs-2021-10-19 branch 2 times, most recently from aa7cb62 to 243e6ed Compare October 21, 2021 18:39
@chalin
Copy link
Contributor Author

chalin commented Oct 22, 2021

Friendly ping to @jkwatson and the @open-telemetry/java-approvers

@jkwatson
Copy link
Contributor

Friendly ping to @jkwatson and the @open-telemetry/java-approvers

Not sure what I'm supposed to do with this PR. Is it possible to see what the change results in?

@chalin
Copy link
Contributor Author

chalin commented Oct 22, 2021

Not sure what I'm supposed to do with this PR. Is it possible to see what the change results in?

Yes, just use one of the preview or redirect-test links in the opening comment.

@chalin
Copy link
Contributor Author

chalin commented Oct 22, 2021

@jkwatson - basically, if you're ok with the website_docs in this PR being published, then we're good to go (please approve the PR in that case).

@chalin chalin force-pushed the chalin-java-docs-2021-10-19 branch from 243e6ed to d388e84 Compare October 22, 2021 19:21
@chalin
Copy link
Contributor Author

chalin commented Oct 22, 2021

Thanks @jkwatson!

@chalin chalin merged commit fcb9dfe into open-telemetry:main Oct 22, 2021
@chalin chalin deleted the chalin-java-docs-2021-10-19 branch October 22, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants